Skip to content

feat: Raise uniform error when passing Series of different lengths to with_columns#2224

Merged
MarcoGorelli merged 1 commit intonarwhals-dev:mainfrom
MarcoGorelli:with-columns-series-err
Mar 16, 2025
Merged

feat: Raise uniform error when passing Series of different lengths to with_columns#2224
MarcoGorelli merged 1 commit intonarwhals-dev:mainfrom
MarcoGorelli:with-columns-series-err

Conversation

@MarcoGorelli
Copy link
Member

closes #2197

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli force-pushed the with-columns-series-err branch from addc2e3 to bbd7b07 Compare March 16, 2025 15:39
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 16, 2025 15:54
Copy link
Member

@dangotbanned dangotbanned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @MarcoGorelli

@MarcoGorelli
Copy link
Member Author

thanks!

@MarcoGorelli MarcoGorelli merged commit 3305aa7 into narwhals-dev:main Mar 16, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different error-ing behaviour with native_namespace=pd compared to the orginal pandas?

2 participants